hachikuji commented on pull request #9912: URL: https://github.com/apache/kafka/pull/9912#issuecomment-763219863
So what I ended up doing is moving the helpers that `TestRaftRequestHandler` needed into `RequestChannel`. Basically this encapsulates the construction of the `RequestChannel.Response`, which seems a bit nicer since it was confusing to see `sendResponse` used for throttling events. It is also nice because it ensures that we do not need to rely on the caller to ensure that `updateErrorMetrics` gets called. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
