hachikuji commented on a change in pull request #9912:
URL: https://github.com/apache/kafka/pull/9912#discussion_r561174514
##########
File path:
clients/src/main/java/org/apache/kafka/common/requests/RequestContext.java
##########
@@ -175,4 +175,19 @@ public String clientId() {
public int correlationId() {
return header.correlationId();
}
+
+ @Override
+ public String toString() {
+ return "RequestContext(" +
+ "header=" + header +
+ ", connectionId='" + connectionId + '\'' +
+ ", clientAddress=" + clientAddress +
+ ", principal=" + principal +
+ ", listenerName=" + listenerName +
+ ", securityProtocol=" + securityProtocol +
+ ", clientInformation=" + clientInformation +
+ ", fromPrivilegedListener=" + fromPrivilegedListener +
+ ", principalSerde=" + principalSerde +
Review comment:
Yeah, I considered it, but didn't see anything in here that looked
sensitive. Most of this information is already included in the request logging.
The client address is not, but that seems ok. Including the principal serde is
annoying, but doesn't seem like a problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
