chia7712 commented on a change in pull request #9926:
URL: https://github.com/apache/kafka/pull/9926#discussion_r560647218
##########
File path:
generator/src/test/java/org/apache/kafka/message/VersionConditionalTest.java
##########
@@ -17,27 +17,25 @@
package org.apache.kafka.message;
-import org.junit.Assert;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.Timeout;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.Timeout;
import java.io.StringWriter;
-import static org.junit.Assert.assertTrue;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+@Timeout(120)
public class VersionConditionalTest {
- @Rule
- final public Timeout globalTimeout = Timeout.millis(120000);
- static void assertEquals(CodeBuffer buffer, String... lines) throws
Exception {
+ static void claimEquals(CodeBuffer buffer, String... lines) throws
Exception {
Review comment:
the build fails due to this renaming.
```
/home/chia7712/kafka/generator/src/test/java/org/apache/kafka/message/IsNullConditionalTest.java:37:
error: cannot find symbol
VersionConditionalTest.assertEquals(buffer,
^
symbol: method assertEquals(CodeBuffer,String,String,String)
location: class VersionConditionalTest
/home/chia7712/kafka/generator/src/test/java/org/apache/kafka/message/IsNullConditionalTest.java:57:
error: cannot find symbol
VersionConditionalTest.assertEquals(buffer,
^
symbol: method
assertEquals(CodeBuffer,String,String,String,String,String)
location: class VersionConditionalTest
/home/chia7712/kafka/generator/src/test/java/org/apache/kafka/message/IsNullConditionalTest.java:76:
error: cannot find symbol
VersionConditionalTest.assertEquals(buffer,
^
symbol: method assertEquals(CodeBuffer,String,String,String)
location: class VersionConditionalTest
/home/chia7712/kafka/generator/src/test/java/org/apache/kafka/message/IsNullConditionalTest.java:96:
error: cannot find symbol
VersionConditionalTest.assertEquals(buffer,
^
symbol: method assertEquals(CodeBuffer,String)
location: class VersionConditionalTest
/home/chia7712/kafka/generator/src/test/java/org/apache/kafka/message/IsNullConditionalTest.java:115:
error: cannot find symbol
VersionConditionalTest.assertEquals(buffer,
^
symbol: method assertEquals(CodeBuffer,String,String,String)
location: class VersionConditionalTest
5 errors
```
##########
File path: generator/src/test/java/org/apache/kafka/message/VersionsTest.java
##########
@@ -41,10 +40,10 @@ private static Versions newVersions(int lower, int higher) {
@Test
public void testVersionsParse() {
- assertEquals(Versions.NONE, Versions.parse(null, Versions.NONE));
- assertEquals(Versions.ALL, Versions.parse(" ", Versions.ALL));
- assertEquals(Versions.ALL, Versions.parse("", Versions.ALL));
- assertEquals(newVersions(4, 5), Versions.parse(" 4-5 ", null));
+ assertEquals(Versions.parse(null, Versions.NONE), Versions.NONE);
Review comment:
please revert those changes as first argument should be "expected" value.
##########
File path: generator/src/test/java/org/apache/kafka/message/VersionsTest.java
##########
@@ -63,17 +62,13 @@ private void testRoundTrip(Versions versions, String
string) {
@Test
public void testIntersections() {
- assertEquals(newVersions(2, 3),
- newVersions(1, 3).intersect(
- newVersions(2, 4)));
- assertEquals(newVersions(3, 3),
- newVersions(0, Short.MAX_VALUE).intersect(
- newVersions(3, 3)));
- assertEquals(Versions.NONE,
- newVersions(9, Short.MAX_VALUE).intersect(
+ assertEquals(newVersions(1, 3).intersect(
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
