ivanyu commented on pull request #9990: URL: https://github.com/apache/kafka/pull/9990#issuecomment-769166332
Yes, looks like a regression. The test ported to 2.6 ([here](https://github.com/apache/kafka/blob/2.6/core/src/test/scala/unit/kafka/server/AdminManagerTest.scala)) works: ```scala @Test def testDescribeConfigsWithConfigurationKeys(): Unit = { EasyMock.expect(zkClient.getEntityConfigs(ConfigType.Topic, topic)).andReturn(TestUtils.createBrokerConfig(brokerId, "zk")) EasyMock.expect(metadataCache.contains(topic)).andReturn(true) EasyMock.replay(zkClient, metadataCache) val resources = Map[ConfigResource, Option[Set[String]]]( new ConfigResource(ConfigResource.Type.TOPIC, topic) -> Some(Set("retention.ms", "retention.bytes", "segment.bytes")) ) val adminManager = createAdminManager() val r = adminManager.describeConfigs(resources, true, false) val resultConfigKeys = r.head._2.entries().asScala.map(e => e.name()).toSet assertEquals(Set("retention.ms", "retention.bytes", "segment.bytes"), resultConfigKeys) } ``` There were some changes of `describeConfigs` signature and code, maybe the bug got in there. The admin client and command line tools can't specify configuration keys ([it's always `null`](https://github.com/apache/kafka/blob/287b600cf712a4a7e9139e15e1151768f67eec75/clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java#L2100)) - I guess that's why the tests are green. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
