mumrah commented on a change in pull request #10003:
URL: https://github.com/apache/kafka/pull/10003#discussion_r567065946



##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -197,7 +204,8 @@ class ReplicaManager(val config: KafkaConfig,
                      val delayedDeleteRecordsPurgatory: 
DelayedOperationPurgatory[DelayedDeleteRecords],
                      val delayedElectLeaderPurgatory: 
DelayedOperationPurgatory[DelayedElectLeader],
                      threadNamePrefix: Option[String],
-                     val alterIsrManager: AlterIsrManager) extends Logging 
with KafkaMetricsGroup {
+                     val alterIsrManager: AlterIsrManager,
+                     usingRaftMetadataQuorum: Boolean) extends Logging with 
KafkaMetricsGroup {

Review comment:
       Could we check if we're in Raft mode using KafkaConfig rather than 
adding a flag here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to