[GitHub] [kafka] ijuma commented on a change in pull request #10003: MINOR: Add HostedPartition.Deferred state in ReplicaManager

[GitBox]

ijuma commented on a change in pull request #10003:
URL: https://github.com/apache/kafka/pull/10003#discussion_r568860838



##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -316,7 +324,7 @@ class ReplicaManager(val config: KafkaConfig,
   private def maybeRemoveTopicMetrics(topic: String): Unit = {
     val topicHasOnlinePartition = allPartitions.values.exists {
       case HostedPartition.Online(partition) => topic == partition.topic
-      case HostedPartition.None | HostedPartition.Offline => false
+      case _ => false

Review comment:
       After this change, we can probably keep `HostedPartition.None | 
HostedPartition.Offline` as it was before, right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org