rondagostino commented on a change in pull request #10005:
URL: https://github.com/apache/kafka/pull/10005#discussion_r567300461



##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -150,7 +167,11 @@ class KafkaApis(val requestChannel: RequestChannel,
     }
 
     forwardingManager match {
-      case Some(mgr) if !request.isForwarded && !controller.isActive =>
+      case Some(mgr) if request.isForwarded && usingRaftMetadataQuorum =>

Review comment:
       I reworked it a bit to clarify the intent, which is to add a log message 
if a Raft-based broker receives a forwarded request; it'll still handle the 
request (and we'll give `NOT_CONTROLLER`).
   
   I'm not sure we should change the logic here and forward a request that 
itself is already forwarded as that opens up the possibility of endless loops.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to