rondagostino commented on a change in pull request #10005:
URL: https://github.com/apache/kafka/pull/10005#discussion_r567313320



##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -249,6 +270,7 @@ class KafkaApis(val requestChannel: RequestChannel,
   }
 
   def handleLeaderAndIsrRequest(request: RequestChannel.Request): Unit = {
+    rejectWithUnsupportedVersionIfUsingRaftMetadataQuorum(request)

Review comment:
       We probably should, yes.  When looking at it, the exclusion should be 
done in `ApiVersion.apiVersionsResponse()`.  But how we can know there if we 
are using a Raft-based metadata quorum is unclear.  We could brute-force send 
in the `KafkaConfig`, but it appears perhaps `Features` might be another way to 
do it.  Have we considered creating a feature for that, do you know?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to