ijuma commented on a change in pull request #10013: URL: https://github.com/apache/kafka/pull/10013#discussion_r567966872
########## File path: core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala ########## @@ -30,6 +30,13 @@ import org.apache.kafka.common.record.RecordBatch import org.apache.kafka.common.requests.TransactionResult import org.apache.kafka.common.utils.{LogContext, ProducerIdAndEpoch, Time} +class TransactionStateTopicPartitionCountViaZooKeeper(zkClient: KafkaZkClient, Review comment: Yeah, I am suggesting you can still have it shared, but as a method in the companion object of one of the classes. And then you can have a simpler method name like `transactionStatePartitionCount` or something. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org