ijuma commented on a change in pull request #10013: URL: https://github.com/apache/kafka/pull/10013#discussion_r567967281
########## File path: core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala ########## @@ -30,6 +30,13 @@ import org.apache.kafka.common.record.RecordBatch import org.apache.kafka.common.requests.TransactionResult import org.apache.kafka.common.utils.{LogContext, ProducerIdAndEpoch, Time} +class TransactionStateTopicPartitionCountViaZooKeeper(zkClient: KafkaZkClient, Review comment: To clarify, it's a bit of an anti pattern to have a whole class when a method would do in Scala. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org