gharris1727 commented on a change in pull request #10016:
URL: https://github.com/apache/kafka/pull/10016#discussion_r568823888
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##########
@@ -171,13 +171,9 @@ protected void close() {
log.warn("Could not stop task", t);
}
}
- if (producer != null) {
- try {
- producer.close(Duration.ofSeconds(30));
- } catch (Throwable t) {
- log.warn("Could not close producer", t);
- }
- }
+
+ closeProducer(30);
+
if (admin != null) {
Review comment:
Yeah, I see that here that the situation doesn't require any plugins to
block, just the framework/clients. I'm sure that had you implemented by
refactoring close, someone could come along and leave the comment "is all of
this necessary? how about just closing the producer instead?"
I'm fine with this fix as-is, and if we notice a resource leak related to
any of the other plugins caused by stalled connectors, we can address them at
that time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
