ijuma commented on a change in pull request #10095:
URL: https://github.com/apache/kafka/pull/10095#discussion_r573849465
##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -1497,6 +1509,9 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:
Boolean, dynamicConfigO
var brokerId: Int = getInt(KafkaConfig.BrokerIdProp)
val nodeId: Int = getInt(KafkaConfig.NodeIdProp)
val processRoles: Set[ProcessRole] = parseProcessRoles()
+ val initialRegistrationTimeoutMs =
getInt(KafkaConfig.InitialBrokerRegistrationTimeoutMs)
+ val brokerHeartbeatIntervalMs =
getInt(KafkaConfig.BrokerHeartbeatIntervalMsProp)
+ val brokerSessionTimeoutMs = getInt(KafkaConfig.BrokerSessionTimeoutMsProp)
Review comment:
It's worth including the explicit type here since it's a public `val`.
Are these meant to be nullable? It may be better to make then `Option[Int]` if
so. Otherwise, we should make them `Int` so that they're easier to use (they're
currently being inferred as `Integer`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
