cmccabe commented on a change in pull request #10095:
URL: https://github.com/apache/kafka/pull/10095#discussion_r573975606
##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -1497,6 +1509,9 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:
Boolean, dynamicConfigO
var brokerId: Int = getInt(KafkaConfig.BrokerIdProp)
val nodeId: Int = getInt(KafkaConfig.NodeIdProp)
val processRoles: Set[ProcessRole] = parseProcessRoles()
+ val initialRegistrationTimeoutMs =
getInt(KafkaConfig.InitialBrokerRegistrationTimeoutMs)
+ val brokerHeartbeatIntervalMs =
getInt(KafkaConfig.BrokerHeartbeatIntervalMsProp)
+ val brokerSessionTimeoutMs = getInt(KafkaConfig.BrokerSessionTimeoutMsProp)
Review comment:
Good point. I added the explicit type of `Int`.
I don't think they need to be nullable... they have reasonable defaults as
usual in KafkaConfig. And they will be ignored altogether when in ZK mode, of
course.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
