mjsax commented on a change in pull request #10102:
URL: https://github.com/apache/kafka/pull/10102#discussion_r574086409
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -776,9 +776,10 @@ void runOnce() {
log.debug("{} punctuators ran.", punctuated);
+ final long beforeCommitTs = now;
final int committed = maybeCommit();
totalCommittedSinceLastSummary += committed;
- final long commitLatency = advanceNowAndComputeLatency();
+ final long commitLatency = Math.max(now - beforeCommitTs, 0);
Review comment:
We could replace `advancedNowAndComputeLatency` by `now =
time.milliseconds()` in `maybeCommit()` though. -- In the original PR, we just
called `advancedNowAndComputeLatency` to keep the patter of a single place in
the code that does call `time.milliseconds`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
