ableegoldman commented on a change in pull request #10102:
URL: https://github.com/apache/kafka/pull/10102#discussion_r574187073
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -776,9 +776,10 @@ void runOnce() {
log.debug("{} punctuators ran.", punctuated);
+ final long beforeCommitTs = now;
final int committed = maybeCommit();
totalCommittedSinceLastSummary += committed;
- final long commitLatency = advanceNowAndComputeLatency();
+ final long commitLatency = Math.max(now - beforeCommitTs, 0);
Review comment:
> Yes, that is a little odd -- as I said, happy to change
advancedNowAndComputeLatency to now = time.milliseconds() within maybeCommit().
Sounds good to me, let's do it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
