[GitHub] [kafka] ableegoldman commented on a change in pull request #10072: KAFKA-9274: Throw TaskCorruptedException instead of TimeoutException when TX commit times out

[GitBox]

ableegoldman commented on a change in pull request #10072:
URL: https://github.com/apache/kafka/pull/10072#discussion_r574778749



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/TaskId.java
##########
@@ -32,6 +33,7 @@
     public final int topicGroupId;
     /** The ID of the partition. */
     public final int partition;
+    public Task task;

Review comment:
       Well, we also use `TaskId` all throughout the StreamsPartitionAssignor, 
and it definitely does not include a reference to a real `Task` object there (I 
think the `TaskId` ultimately comes from the PartitionGrouper`)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org