ableegoldman commented on a change in pull request #10072:
URL: https://github.com/apache/kafka/pull/10072#discussion_r579430512
##########
File path: docs/streams/upgrade-guide.html
##########
@@ -127,6 +127,15 @@ <h3><a id="streams_api_changes_280"
href="#streams_api_changes_280">Streams API
into the constructor, it is no longer required to set mandatory
configuration parameters
(cf. <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-680%3A+TopologyTestDriver+should+not+require+a+Properties+argument";>KIP-680</a>).
</p>
+ <p>
+ Kafka Streams is now handling <code>TimeoutException</code> thrown by
the consumer, producer, and admin client.
+ If a timeout occurs on a task, Kafka Streams moves to the next task
and retries to make progress on the failed
+ task in the next iteration.
+ To bound how long Kafka Streams retries a task, you can set
<code>task.timeout.ms</code> (default is 5 minutes).
+ If a task does not make progress within the specified task timeout
(the timeout it tracked on a per-task basis)
Review comment:
nit: the timeout _is_ tracked on a per-task basis
##########
File path: docs/streams/upgrade-guide.html
##########
@@ -127,6 +127,15 @@ <h3><a id="streams_api_changes_280"
href="#streams_api_changes_280">Streams API
into the constructor, it is no longer required to set mandatory
configuration parameters
(cf. <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-680%3A+TopologyTestDriver+should+not+require+a+Properties+argument";>KIP-680</a>).
</p>
+ <p>
+ Kafka Streams is now handling <code>TimeoutException</code> thrown by
the consumer, producer, and admin client.
+ If a timeout occurs on a task, Kafka Streams moves to the next task
and retries to make progress on the failed
+ task in the next iteration.
+ To bound how long Kafka Streams retries a task, you can set
<code>task.timeout.ms</code> (default is 5 minutes).
+ If a task does not make progress within the specified task timeout
(the timeout it tracked on a per-task basis)
Review comment:
or better yet
```suggestion
If a task does not make progress within the specified task timeout,
which is tracked on a per-task basis,
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
