cmccabe commented on a change in pull request #10066:
URL: https://github.com/apache/kafka/pull/10066#discussion_r578711547
##########
File path: checkstyle/import-control.xml
##########
@@ -99,6 +100,7 @@
<allow pkg="org.apache.kafka.common.config" />
<allow pkg="org.apache.kafka.common.metrics" />
<allow pkg="org.apache.kafka.common.security" />
+ <allow class="org.apache.kafka.common.requests.ApiVersionsResponse" />
Review comment:
Yeah, the API versions response is pretty special in the protocol.
Fortunately or unfortunately, it's not treated as a generic response. I tried
to think of some ways to avoid this dependency but they all ended up being kind
of like obfuscation.
Even if we chose to make this a `Supplier<AbstractResponse>`, that's still
in the requests package....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
