cmccabe commented on a change in pull request #10066:
URL: https://github.com/apache/kafka/pull/10066#discussion_r578711547
##########
File path: checkstyle/import-control.xml
##########
@@ -99,6 +100,7 @@
<allow pkg="org.apache.kafka.common.config" />
<allow pkg="org.apache.kafka.common.metrics" />
<allow pkg="org.apache.kafka.common.security" />
+ <allow class="org.apache.kafka.common.requests.ApiVersionsResponse" />
Review comment:
> I guess I would say that the dependency is there regardless of how we
choose to hide it since we have to go through ChannelBuilders to build the
authenticator, and the authenticator does depend on the request APIs.
Yeah, the API versions response is pretty special in the protocol.
Fortunately or unfortunately, it's not treated as a generic response. I tried
to think of some ways to avoid this dependency but they all ended up being kind
of like obfuscation.
> Could we make it work by changing the supplier to something more generic?
Maybe I'm misinterpreting the suggestion, but if we choose to make this a
`Supplier<AbstractResponse>`, that's still in the requests package....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
