jolshan commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r583183607
##########
File path: core/src/main/scala/kafka/log/LogCleaner.scala
##########
@@ -582,13 +586,16 @@ private[log] class Cleaner(val id: Int,
transactionMetadata.addAbortedTransactions(abortedTransactions)
val retainDeletesAndTxnMarkers = currentSegment.lastModified >
deleteHorizonMs
- info(s"Cleaning $currentSegment in log ${log.name} into
${cleaned.baseOffset} " +
+ info(s"Cleaning $currentSegment in log ${log.name} into
${currentSegment.baseOffset} " +
Review comment:
I think I was concerned about putting this information in the try block
and it not printing. But I looking at it again, it's not a huge deal not to log
in that case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
