[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

[GitBox]

jolshan commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r583202007



##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -209,6 +209,11 @@ case object LeaderOffsetIncremented extends 
LogStartOffsetIncrementReason {
 case object SegmentDeletion extends LogStartOffsetIncrementReason {
   override def toString: String = "segment deletion"
 }
+
+case object SegmentCompaction extends LogStartOffsetIncrementReason {

Review comment:
       I took a quick look at the others that extend 
LogStartOffsetIncrementReason and SegementDeletionReason. I think this is why I 
chose Log and Segment respectively.
   ```
   RetentionMsBreach extends SegmentDeletionReason 
   RetentionSizeBreach extends SegmentDeletionReason 
   StartOffsetBreach extends SegmentDeletionReason
   LogRecovery extends SegmentDeletionReason
   LogTruncation extends SegmentDeletionReason 
   LogRoll extends SegmentDeletionReason 
   LogDeletion extends SegmentDeletionReason 
   ```
   
   ```
   ClientRecordDeletion extends LogStartOffsetIncrementReason
   LeaderOffsetIncremented extends LogStartOffsetIncrementReason 
   SegmentDeletion extends LogStartOffsetIncrementReason 
   SnapshotGenerated extends LogStartOffsetIncrementReason 
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org