cmccabe opened a new pull request #10281: URL: https://github.com/apache/kafka/pull/10281
Previously, we relied solely on the broker to enforce request.timeout.ms. If the broker failed to enforce this timeout, the admin client would hang until the call's API timeout hit, which would return an error to the caller. With this change, the Admin Client will time out the call after request.timeout.ms even if the broker does not. This is useful because if the broker is hanging for some reason, we don't want to use up all of our default.api.timeout.ms. Since we would still prefer for the broker to initiate the timeout, we arrange for the client request deadline to be a few milliseconds after the broker request deadline. Another issue that this PR fixes is that previously, the admin client would not initiate a disconnect from a broker which was able to accept connections, but which didn't allow us to send any requests. With this PR, we handle this case by closing the connection and putting the calls back into the list of calls which are pending a node assignment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
