jolshan commented on a change in pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#discussion_r593771946
##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -661,11 +661,21 @@ class KafkaApis(val requestChannel: RequestChannel,
val versionId = request.header.apiVersion
val clientId = request.header.clientId
val fetchRequest = request.body[FetchRequest]
+ val (topicIds, topicNames) =
+ if (fetchRequest.version() >= 13)
+ metadataCache.topicIdInfo()
+ else
+ (Collections.emptyMap[String, Uuid](), Collections.emptyMap[Uuid,
String]())
+
val fetchContext = fetchManager.newContext(
Review comment:
For the most part, this is what we do. But we also have to keep track of
unresolved names right? FetchSession makes this more complicated. We may get a
topic ID that we can't resolve, but with a subsequent update we can. I'm not
100% sure of the logistics of fetch sessions, but it doesn't seem like a good
practice to leave unresolved IDs out of the session.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
