jolshan commented on a change in pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#discussion_r593772326
##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -661,11 +661,21 @@ class KafkaApis(val requestChannel: RequestChannel,
val versionId = request.header.apiVersion
val clientId = request.header.clientId
val fetchRequest = request.body[FetchRequest]
+ val (topicIds, topicNames) =
+ if (fetchRequest.version() >= 13)
+ metadataCache.topicIdInfo()
+ else
+ (Collections.emptyMap[String, Uuid](), Collections.emptyMap[Uuid,
String]())
+
val fetchContext = fetchManager.newContext(
+ fetchRequest.version,
fetchRequest.metadata,
- fetchRequest.fetchData,
- fetchRequest.toForget,
- fetchRequest.isFromFollower)
+ fetchRequest.isFromFollower,
+ fetchRequest.fetchDataAndError(topicNames),
+ fetchRequest.toForgetAndIds(topicNames),
Review comment:
I would think so? The goal was for when the IDs are resolved, the path
would be the same. And I think we decided that TOPIC_AUTHORIZATION_FAILED is
the correct error when we don't have read permissions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
