vvcephei commented on a change in pull request #10392:
URL: https://github.com/apache/kafka/pull/10392#discussion_r600124984
##########
File path:
clients/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataManager.java
##########
@@ -71,7 +71,7 @@
* <p>
* <pre>
* +---------------------+ +----------------------+
- * |COPY_SEGMENT_STARTED |----------->|COPY_SEGMENT_FINISHED |
+ * |COPY_SEGMENT_STARTED |----------->|COPY_SEGMENT_FINISHED |
Review comment:
These were just warnings, but they were the only two warnings in the
project, so I fixed them. We just need to XML-escape the `>` character.
##########
File path:
streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java
##########
@@ -41,8 +41,8 @@
import org.apache.kafka.common.utils.Time;
import org.apache.kafka.streams.errors.LogAndContinueExceptionHandler;
import org.apache.kafka.streams.errors.TopologyException;
-import org.apache.kafka.streams.internals.KeyValueStoreFacade;
-import org.apache.kafka.streams.internals.WindowStoreFacade;
+import org.apache.kafka.streams.test.internal.KeyValueStoreFacade;
+import org.apache.kafka.streams.test.internal.WindowStoreFacade;
Review comment:
Javadoc is unable to generate docs for this (TopologyTestDriver) file
because it depends on these classes, which are also in test-utils, but are
excluded in the build.gradle spec.
I was unable to override the exclusion with a more specific inclusion, so
instead I just moved these classes to a different package that matches only the
"include" patterns in `:streams:test-utils:javadoc`.
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java
##########
@@ -237,7 +237,7 @@ private static boolean isRecoverable(final KafkaException
uncaughtException) {
* @throws IllegalStateException if EOS is disabled
* @throws TaskMigratedException
*/
- void commitTransaction(final Map<TopicPartition, OffsetAndMetadata>
offsets,
+ protected void commitTransaction(final Map<TopicPartition,
OffsetAndMetadata> offsets,
Review comment:
Needed this so I could move the subclass to a different package. I think
it's still just as obviously inappropriate for users to subclass this class,
since it's in the `internals` package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
