vvcephei commented on a change in pull request #10392:
URL: https://github.com/apache/kafka/pull/10392#discussion_r600548484
##########
File path:
streams/test-utils/src/main/java/org/apache/kafka/streams/test/internal/KeyValueStoreFacade.java
##########
@@ -14,7 +14,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.kafka.streams.internals;
+package org.apache.kafka.streams.test.internal;
Review comment:
Yes, that's exactly right. I agree it's not great. Maybe a better
alternative is to just not try to mark these classes as "internal". It should
be pretty hard to get confused about their usage, and apparently we have to
include them in the Javadoc anyway, so it's probably fine to just move them up
a level and drop `internal`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
