kowshik commented on a change in pull request #10424:
URL: https://github.com/apache/kafka/pull/10424#discussion_r603486431
##########
File path:
clients/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentMetadata.java
##########
@@ -56,14 +56,14 @@
private final int brokerId;
/**
- * Maximum timestamp in the segment
+ * Maximum timestamp in milli seconds in the segment
*/
- private final long maxTimestamp;
+ private final long maxTimestampMillis;
Review comment:
The more common way of using time units in variables seems to be to use
the abbreviated suffix, https://github.com/apache/kafka/search?q=timeMs. In
this case it would be `maxTimstampMs`.
(same comment applies for other variables below).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
