ccding commented on a change in pull request #10405:
URL: https://github.com/apache/kafka/pull/10405#discussion_r605901984
##########
File path: clients/src/main/java/org/apache/kafka/common/record/FileRecords.java
##########
@@ -195,6 +199,17 @@ public int append(MemoryRecords records) throws
IOException {
*/
public void flush() throws IOException {
channel.force(true);
+ if (needFlushParentDir.getAndSet(false)) {
Review comment:
Per our offline discussion, we leave it unchanged. If the flush causes
an IOException, the partition will go offline and doesn't have further chance
to call flush again.
##########
File path: clients/src/main/java/org/apache/kafka/common/record/FileRecords.java
##########
@@ -195,6 +199,17 @@ public int append(MemoryRecords records) throws
IOException {
*/
public void flush() throws IOException {
channel.force(true);
+ if (needFlushParentDir.getAndSet(false)) {
Review comment:
Per our offline discussion, we leave it unchanged. If the flush causes
an IOException, the partition will go offline and doesn't have further chances
to call flush again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
