ccding commented on a change in pull request #10405:
URL: https://github.com/apache/kafka/pull/10405#discussion_r605902765
##########
File path: core/src/main/scala/kafka/log/LogSegment.scala
##########
@@ -490,11 +490,14 @@ class LogSegment private[log] (val log: FileRecords,
* Change the suffix for the index and log files for this log segment
* IOException from this method should be handled by the caller
*/
- def changeFileSuffixes(oldSuffix: String, newSuffix: String): Unit = {
+ def changeFileSuffixes(oldSuffix: String, newSuffix: String,
needFlushParentDir: Boolean = true): Unit = {
Review comment:
set the flag to false for rename.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
