hachikuji commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r609983533
##########
File path: core/src/main/scala/kafka/log/LogCleaner.scala
##########
@@ -701,11 +719,17 @@ private[log] class Cleaner(val id: Int,
// if any messages are to be retained, write them out
val outputBuffer = result.outputBuffer
if (outputBuffer.position() > 0) {
+ if (destSegment.isEmpty) {
+ // create a new segment with a suffix appended to the name of the
log and indexes
+ destSegment = Some(LogCleaner.createNewCleanedSegment(log,
result.minOffset()))
+ transactionMetadata.cleanedIndex = Some(destSegment.get.txnIndex)
Review comment:
Sorry to keep pressing this, but do you have an update here? It would be
nice to keep the behavior here on par with the existing implementation. Really
if you think about the way this is working, we could write to the cleaned
segment directly from `filterTo` instead of building a buffer in memory, but we
can leave that as a follow-up improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
