kpatelatwork commented on a change in pull request #10528:
URL: https://github.com/apache/kafka/pull/10528#discussion_r614129645
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/storage/OffsetStorageWriter.java
##########
@@ -120,6 +120,13 @@ public synchronized boolean beginFlush() {
return true;
}
+ /**
+ * @return whether there's anything to flush right now.
+ */
+ public boolean willFlush() {
Review comment:
synchronized? All other access to `data` seems to be in synchronized
methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
