mjsax commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r614536011
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java
##########
@@ -118,20 +142,47 @@
final ProcessorGraphNode<K1, V2> otherWindowedStreamsNode = new
ProcessorGraphNode<>(otherWindowStreamProcessorName,
otherWindowStreamProcessorParams);
builder.addGraphNode(otherGraphNode, otherWindowedStreamsNode);
+ Optional<StoreBuilder<WindowStore<KeyAndJoinSide<K1>,
LeftOrRightValue<V1, V2>>>> outerJoinWindowStore = Optional.empty();
+ if (leftOuter || rightOuter) {
+ final String outerJoinSuffix = "-shared-outer-join-store";
+
+ // Get the suffix index of the joinThisGeneratedName to build the
outer join store name.
+ final String outerJoinStoreGeneratedName =
KStreamImpl.OUTERSHARED_NAME
+ + joinThisGeneratedName.substring(
+ rightOuter
+ ? KStreamImpl.OUTERTHIS_NAME.length()
+ : KStreamImpl.JOINTHIS_NAME.length());
Review comment:
I agree that we should not use one more index to avoid compatibility
issues... Maybe the question is really (just for my better understanding), what
would the name be, ie, could be give a concrete example (with and without
`Named` parameter)? That is also why I asked for a test using
`TopologyDescription` -- makes it easier to wrap my head around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
