[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

[GitBox]

showuon commented on a change in pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#discussion_r621951920



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##########
@@ -108,6 +107,8 @@ private boolean allSubscriptionsEqual(Set<String> allTopics,
                 subscribedTopics.addAll(subscription.topics());
             } else if (!(subscription.topics().size() == 
subscribedTopics.size()
                 && subscribedTopics.containsAll(subscription.topics()))) {
+                // we don't need consumerToOwnedPartitions in general assign 
case
+                consumerToOwnedPartitions = null;

Review comment:
       I'll nullify it for now before invoking `generalAssign` to make the PR 
simple. And then adopt your 2nd option in another ticket (KAFKA-12654). Thank 
you. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org