[GitHub] [kafka] feyman2016 commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

[GitBox]

feyman2016 commented on a change in pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#discussion_r623971200



##########
File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java
##########
@@ -168,12 +179,12 @@ Builder withMemoryPool(MemoryPool pool) {
             return this;
         }
 
-        Builder withAppendLingerMs(int appendLingerMs) {
+        public Builder withAppendLingerMs(int appendLingerMs) {

Review comment:
       Mark these methods as `public` to be reused in `SnapshotWriterTest`, in 
`SnapshotWriterTest`, it need a way to advance the high watermark of the 
snapshot validation won't be passed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org