[GitHub] [kafka] feyman2016 commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

[GitBox]

feyman2016 commented on a change in pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#discussion_r623972347



##########
File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java
##########
@@ -108,6 +108,17 @@
 
     private final List<RaftResponse.Outbound> sentResponses = new 
ArrayList<>();
 
+    public static void advanceHighWatermark(RaftClientTestContext context,

Review comment:
       This method will be called in both `KafkaRaftClientSnapshotTest` and 
`SnapshotWriterTest`, so mark it as public




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org