[GitHub] [kafka] spena commented on a change in pull request #10640: KAFKA-10847: Set StreamsConfig on InternalTopologyDriver before writing topology

[GitBox]

spena commented on a change in pull request #10640:
URL: https://github.com/apache/kafka/pull/10640#discussion_r627598006



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java
##########
@@ -290,6 +290,10 @@ public void buildAndOptimizeTopology(final Properties 
props) {
             }
 
             if (streamGraphNode.allParentsWrittenToTopology() && 
!streamGraphNode.hasWrittenToTopology()) {
+                if (props != null && !props.isEmpty()) {
+                    internalTopologyBuilder.setStreamsConfig(new 
StreamsConfig(props));

Review comment:
       Ksql calls the `StreamsBuilder` first, which calls the 
`StreamStreamJoinNode.writeToTopology()` at some point. When `KafkaStreams` is 
called later, the shared state store was already added to the join nodes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org