spena commented on a change in pull request #10640:
URL: https://github.com/apache/kafka/pull/10640#discussion_r627599049
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/GraphNode.java
##########
@@ -119,6 +120,11 @@ public Integer buildPriority() {
public abstract void writeToTopology(final InternalTopologyBuilder
topologyBuilder);
Review comment:
I don't know if removing this method and replace it with the below
method with the properties parameter is better. There are several classes that
implement `GraphNode` and that will need to accept the new parameter. It is an
internal interface and impl, though. Do you think I should go with that
approach instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
