[GitHub] [kafka] jsancio commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

[GitBox]

jsancio commented on a change in pull request #10705:
URL: https://github.com/apache/kafka/pull/10705#discussion_r633930529



##########
File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java
##########
@@ -56,24 +57,17 @@
         void handleSnapshot(SnapshotReader<T> reader);
 
         /**

Review comment:
       I'll update the documentation but in Raft epochs are not guarantee to 
have a leader. If there is a leader for an epoch then there is one and only one 
leader. So that means that the client could see.
   ```
   handleLeaderChange(LeaderAndEpoch(nodeId=0, epoch=0))
   handleLeaderChange(LeaderAndEpoch(nodeId=-1, epoch=1))
   handleLeaderChange(LeaderAndEpoch(nodeId=1, epoch=1))
   ```
   Or this for that matter
   ```
   handleLeaderChange(LeaderAndEpoch(nodeId=0, epoch=0))
   handleLeaderChange(LeaderAndEpoch(nodeId=-1, epoch=1))
   handleLeaderChange(LeaderAndEpoch(nodeId=-1, epoch=2))
   handleLeaderChange(LeaderAndEpoch(nodeId=1, epoch=2))
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org