[GitHub] [kafka] jsancio commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

[GitBox]

jsancio commented on a change in pull request #10705:
URL: https://github.com/apache/kafka/pull/10705#discussion_r633958458



##########
File path: 
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##########
@@ -936,21 +944,13 @@ private QuorumController(LogContext logContext,
         this.replicationControl = new 
ReplicationControlManager(snapshotRegistry,
             logContext, defaultReplicationFactor, defaultNumPartitions,
             configurationControl, clusterControl, controllerMetrics);
-        this.logManager = logManager;
+        this.raftClient = raftClient;
         this.metaLogListener = new QuorumMetaLogListener();
-        this.curClaimEpoch = -1L;
-        this.lastCommittedOffset = snapshotReader.epoch();
+        this.curClaimEpoch = -1;
+        this.lastCommittedOffset = -1L;
         this.writeOffset = -1L;
 
-        while (snapshotReader.hasNext()) {
-            List<ApiMessage> batch = snapshotReader.next();
-            long index = 0;
-            for (ApiMessage message : batch) {
-                replay(message, snapshotReader.epoch(), index++);
-            }
-        }
-        snapshotRegistry.createSnapshot(lastCommittedOffset);

Review comment:
       Okay. I didn't want do this as part of the merge commit but I'll add it 
back as a separate commit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org