[GitHub] [kafka] cmccabe commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

[GitBox]

cmccabe commented on a change in pull request #10705:
URL: https://github.com/apache/kafka/pull/10705#discussion_r635614984



##########
File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java
##########
@@ -56,24 +57,17 @@
         void handleSnapshot(SnapshotReader<T> reader);
 
         /**

Review comment:
       It sounds like the invariant here is that while `handleLeaderChange` may 
be called multiple times for the same epoch, only the last call will have a 
valid (non-negative) node id associated with it. Can you add a JavaDoc comment 
like this to the API?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org