Moovlin commented on a change in pull request #10853:
URL: https://github.com/apache/kafka/pull/10853#discussion_r648550375
##########
File path: core/src/main/scala/kafka/admin/TopicCommand.scala
##########
@@ -574,6 +574,7 @@ object TopicCommand extends Logging {
if (has(alterOpt)) {
CommandLineUtils.checkInvalidArgsSet(parser, options,
Set(bootstrapServerOpt, configOpt), Set(alterOpt),
Some(kafkaConfigsCanAlterTopicConfigsViaBootstrapServer))
+ CommandLineUtils.checkInvalidArgs(parser, options,
replicationFactorOpt, Set(alterOpt))
Review comment:
I realize that I pushed a change in my branch already which doesn't fix
this as I expected (my testing procedure was incorrect). Thinking about this
change more though. Should it be that replication-factor cannot be used with
replica-assignment? As I understand it, replication-assignment is the accepted
way to adjust the replication factor for a particular topic and this just
exposes a more convenient way to make that change. Please correct my
understanding if it's wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
