jolshan commented on a change in pull request #10584:
URL: https://github.com/apache/kafka/pull/10584#discussion_r649360987
##########
File path: core/src/test/scala/unit/kafka/server/MetadataRequestTest.scala
##########
@@ -234,6 +235,32 @@ class MetadataRequestTest extends
AbstractMetadataRequestTest {
}
}
+ @Test
+ def testInvalidMetadataRequestReturnsError(): Unit = {
Review comment:
I guess the only other reason I tested the whole path was to make sure
the response could be sent back (if the name was null, it could not have), but
it should suffice to also have a non-null check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
