jolshan commented on a change in pull request #10584:
URL: https://github.com/apache/kafka/pull/10584#discussion_r649425805
##########
File path: core/src/test/scala/unit/kafka/server/MetadataRequestTest.scala
##########
@@ -234,6 +235,32 @@ class MetadataRequestTest extends
AbstractMetadataRequestTest {
}
}
+ @Test
+ def testInvalidMetadataRequestReturnsError(): Unit = {
Review comment:
I must have missed this comment earlier. I moved the test to
KafkaApisTest. There we don't check if the response is built since that is part
of the request/response handling code. From what I saw the other invalid tests
were very focused on one thing.
I think the biggest question is whether we care to test the null name is
correctly being set to the empty string. I agree it is good not to start and
stop another kafka cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
