stan-confluent opened a new pull request #10915:
URL: https://github.com/apache/kafka/pull/10915


   The changes in this PR enable connecting VS Code's remote debugger to a 
system test running locally with ducker-ak.
   Changes include:
   - added zip_safe=False to setup.py - this enables installing kafkatest 
module together with source code when running `python setup.py  
develop/install`.
   - install [debugpy](https://github.com/microsoft/debugpy) on ducker nodes
   - expose 5678 (default debugpy port) on ducker01 node - ducker01 is the one 
that actually executes tests, so that's where you'd connect to.
   - added `-d|--debug` option to `ducker-ak test` command - if used, tests 
will run via `python3.7 -m debugpy` command, which would listen on 5678 and 
pause until debugger is connected.
   - changed the logic of the `ducker-ak test` command so that ducktape args 
are collected separately after `--` - otherwise any argument we add to the 
`test` command in the future might potentially
   shadow a similar ducktape argument. 
        - we don't really check that `ducktape_args` are args while 
`test_name_args` are actual test names, so the difference between the two is 
minimal actually - most importantly we do check that `test_name_args` is not 
empty, but we are ok if `ducktape_args` is.
   
   Tested: wrote a small test extending `KafkaTest` and verified it is executed 
with and without debug flag (to be absolutely fair, the test failed in both 
cases, but I was looking at whether the debugger connects correctly or not - it 
does). Ran it with `-- --debug` too to make sure ducktape args are passed 
correctly.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to