cmccabe commented on a change in pull request #10812:
URL: https://github.com/apache/kafka/pull/10812#discussion_r658330409
##########
File path:
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java
##########
@@ -269,7 +269,10 @@ public void testSnapshotSaveAndLoad() throws Throwable {
reader = logEnv.waitForSnapshot(snapshotLogOffset);
SnapshotReader<ApiMessageAndVersion> snapshot =
createSnapshotReader(reader);
assertEquals(snapshotLogOffset,
snapshot.lastContainedLogOffset());
- checkSnapshotContents(fooId, brokerEpochs, snapshot);
+ checkSnapshotContent(
Review comment:
Nitpick: I think in this case this would be more readable on 2 lines
rather than 4.
##########
File path:
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java
##########
@@ -282,7 +285,71 @@ public void testSnapshotSaveAndLoad() throws Throwable {
logEnv.waitForSnapshot(snapshotLogOffset)
);
assertEquals(snapshotLogOffset,
snapshot.lastContainedLogOffset());
- checkSnapshotContents(fooId, brokerEpochs, snapshot);
+ checkSnapshotContent(
Review comment:
Same here -- 2 lines would be better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
