jsancio commented on a change in pull request #10812:
URL: https://github.com/apache/kafka/pull/10812#discussion_r658353741
##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -1049,6 +1052,7 @@ object KafkaConfig {
.defineInternal(BrokerHeartbeatIntervalMsProp, INT,
Defaults.BrokerHeartbeatIntervalMs, null, MEDIUM, BrokerHeartbeatIntervalMsDoc)
.defineInternal(BrokerSessionTimeoutMsProp, INT,
Defaults.BrokerSessionTimeoutMs, null, MEDIUM, BrokerSessionTimeoutMsDoc)
.defineInternal(MetadataLogDirProp, STRING, null, null, HIGH,
MetadataLogDirDoc)
+ .defineInternal(MetadataSnapshotMinNewRecordBytesProp, INT,
Defaults.MetadataSnapshotMinNewRecordBytes, atLeast(1), HIGH,
MetadataSnapshotMinNewRecordBytesDoc)
Review comment:
Sounds good to me. I wasn't sure that we wanted to support for this
value to be greater than `Int.MaxValue`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
