mjsax commented on a change in pull request #10813:
URL: https://github.com/apache/kafka/pull/10813#discussion_r661680528
##########
File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
##########
@@ -1426,6 +1425,9 @@ private void verifyMaxInFlightRequestPerConnection(final
Object maxInFlightReque
public Serde defaultKeySerde() {
final Object keySerdeConfigSetting =
get(DEFAULT_KEY_SERDE_CLASS_CONFIG);
try {
+ if (keySerdeConfigSetting == null) {
+ return null;
Review comment:
Well, I think to argue that we might want to change the
`AbstractProcessorContext`? Instead of making the call in the constructor, we
update `keySerde()` and `valueSerde()` method to make the call:
```
public Serde<?> keySerde() {
if (keySerde == null) {
keySerde = config.defaultValueSerde();
}
return keySerde;
}
```
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
