mjsax commented on a change in pull request #10813:
URL: https://github.com/apache/kafka/pull/10813#discussion_r661685610
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedDeserializer.java
##########
@@ -39,7 +39,10 @@ public ChangedDeserializer(final Deserializer<T> inner) {
@Override
public void setIfUnset(final Deserializer<Void> defaultKeyDeserializer,
final Deserializer<T> defaultValueDeserializer) {
Review comment:
That's a good point... Could we add an internal interface "SerdeGetter"
(for lack of a better name), that both `ProcessroContext` and
`StateStoreContext` extends? And `SerdeGetter` has two methods `keySerder()`
and `valueSerde()` ? For this case, we don't need any refactoring (I would
hope) and could pass `SerdeGetter` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
