mjsax commented on a change in pull request #10813:
URL: https://github.com/apache/kafka/pull/10813#discussion_r661899168
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/KeyAndJoinSideDeserializer.java
##########
@@ -31,13 +32,14 @@
this.keyDeserializer = keyDeserializer;
}
+ @SuppressWarnings("unchecked")
@Override
- public void setIfUnset(final Deserializer<K> defaultKeyDeserializer, final
Deserializer<Void> defaultValueDeserializer) {
+ public void setIfUnset(final SerdeGetter getter) {
if (keyDeserializer == null) {
- keyDeserializer = Objects.requireNonNull(defaultKeyDeserializer,
"defaultKeyDeserializer cannot be null");
+ keyDeserializer = (Deserializer<K>)
Objects.requireNonNull(getter.keySerde().deserializer(),
"defaultKeyDeserializer cannot be null");
Review comment:
as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
