cmccabe commented on a change in pull request #10931:
URL: https://github.com/apache/kafka/pull/10931#discussion_r663269838
##########
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##########
@@ -264,19 +266,13 @@ class BrokerServer(
/* Add all reconfigurables for config change notification before
starting the metadata listener */
config.dynamicConfig.addReconfigurables(this)
- val clientQuotaMetadataManager = new ClientQuotaMetadataManager(
- quotaManagers, socketServer.connectionQuotas, quotaCache)
+ // TODO : check that we're properly handling "ConfigType" Client, User,
and Ip (which are not
Review comment:
It should work, but I need to do more testing. I'll take a look next
week when I add more tests. The quotas stuff should be handled through the
client quotas manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
